voku/agent-learning

Fixed

• Cli::parseOptions() used foreach ($tokens as $index => $token) with a manual $index++ to skip a consumed option value. foreach ignores manual mutation of the loop variable, so the consumed value was re-read on the next iteration and pushed onto $arguments as a bogus leading positional argument. Any command that reads its primary ID from $arguments[0] (proposal-approve, proposal-reject, proposal-mark-applied, finding-transition, and constraint-export/ constraint-activate/constraint-loop when given a bare ID) silently operated on the wrong record whenever at least one --option value pair preceded it. Switched to an explicit indexed for loop (matching the already-correct pattern in the sibling voku/agent-recall-compiler package) and added a regression test that exercises proposal-approve through Cli::run() with space-separated options.

Added

• Add validating recall history in learning root checks

Refactored

• Consolidate learning root resolution

Added

• Add strict recall-selection and per-guidance outcome event models, parsers, and JSONL repositories.
• Add deterministic GuidanceUsageProjector summaries for eligibility, selection, application, explicit outcomes, distinct tasks, timestamps, and evidence event IDs.
• Add typed evolution decisions for promotion, staleness, replacement, conflict, and no-action review results.
• Add separate conservative policies for finding-to-memory, memory-to-skill, skill-to-constraint, memory staleness, skill staleness, and constraint review.
• Add guidance-evaluate CLI to validate event histories, print deterministic usage summaries and decisions, and optionally write reviewable candidate proposals.
• Add idempotent candidate proposal writing with preserved event provenance under evolution_decision.
• Add guidance-evaluation schema documentation and a complete fixture showing findings to memory to recalled outcomes to skill-promotion candidate.
• Add regression coverage for deterministic projection, malformed and duplicate events, selected/applied/helpful separation, promotion gates, harmful blockers, stale review behavior, constraint inactivity, candidate provenance, and idempotent writes.

Changed

• Allow OutcomeRepository validation to read new guidance-outcome.* event rows alongside legacy aggregate outcome records.
• Update README and bundled skills to document immutable event projection, candidate-only writes, and the human approval gate.

Added

• Add typed learning triage with LearningClassification values for CREATE_SKILL, UPDATE_SKILL, ADD_LEARNING_NOTE, and IGNORE.
• Add ValidationCase support so findings, consolidation results, and proposals can carry concrete given / when / then behavior checks.
• Add optional classification, pattern_key, and validation_case fields to findings.
• Add optional learning_decision, pattern_key, validation_case, and overlap_check fields to consolidation results and proposals.

Changed

• Update consolidation prompts to default useful raw lessons to ADD_LEARNING_NOTE, prefer UPDATE_SKILL over duplicate skill creation, and reject praise, self-justification, or generic advice.
• Require CREATE_SKILL proposals to prove existing skill overlap was inspected and that maximum overlap is not above 50%.
• Preserve learning triage metadata when importing consolidation results into candidate proposals.

Added

• Add constraint-activate to write active constraint manifests from approved or applied constraint proposals.
• Add constraint-loop to export, apply, and activate generated constraints with one explicit tooling command.
• Add learning-root config.json path settings for project_root, constraint_generation_dir, and active_constraints_dir.

Changed

• Resolve constraint example, generation-package, and active-manifest paths from CLI options, learning-root configuration, or legacy project-root inference.

Added

• Add typed constraint promotion models (ConstraintSpecification, ConstraintEngine, Detectability, FalsePositiveRisk) for hard-constraint candidates.
• Add promotion-gate validation for confirmed findings, scope, boundaries, detectability, validation commands, false-positive risk, and engine-compatible target paths.
• Add constraint-export to write generation packages containing specifications, source findings/proposals, examples, validation plans, and generation prompts.
• Add generated-rule outcome result types such as violation_detected, false_positive, rule_suppressed, and rule_disabled.

Changed

• Require generated files, registration file, commit, tests, validation result, and content hashes when applying constraint proposals.

Added

• Add Active Guidance modeling and repository to parse/load active guidance files.
• Add Rejection filtering via a repository and selector to skip proposing previously rejected items.
• Add structured JSON-based consolidation input prompt formatting inside fenced JSON blocks for secure LLM parsing.
• Add consolidation result parsing and schema validation supporting concrete result types (ADD, DELETE, REPLACE, REJECT, NO_DURABLE_LEARNING).
• Add proposal importer to atomically write candidate proposals.
• Add transition managers for atomic finding and proposal lifecycle operations (approvals, rejections, application states) with rollback support.
• Add outcome logging and repository to track applied proposal outcomes.
• Integrated all new operations into the CLI tool (proposal-import, finding-transition, proposal-approve, proposal-reject, proposal-mark-applied).

Added

• Add deterministic multi-selector consolidation preparation with repeatable --finding, --task, --ticket, and --scope selectors plus --since and --until date filters.
• Print selected findings before writing consolidation input.
• Append templates/consolidation-prompt.md from the learning root during prepare.
• Add proposal lifecycle directory validation through ProposalLifecycle.
• Add FindingSelection for explicit consolidation input selection.

Changed

• Replace the project-specific default task ID pattern with a generic default that accepts IDs like PROJECT-123, GH-123, and TODO@path.
• Rename DecisionRecorder to DecisionHistoryValidator because the class validates history and does not record decisions yet.
• Document the difference between proposal actions and proposal lifecycle status.
• Remove host-project-specific examples and local filesystem links from package documentation and fixtures.

Fixed

• Reject invalid finding status and validation_status combinations.
• Reject invalid proposal action and status combinations, such as REJECT with approved.
• Reject proposal files whose embedded status does not match their proposals/<status>/ directory.
• Validate approved_at timestamps on proposals when approval metadata is present.

Added

• Initial CLI for validating findings, proposals, and decision history.
• Initial consolidation prompt generation for one task selector.
• Append templates/consolidation-prompt.md from the learning root during prepare.
• Finding, proposal, evidence, JSONL, redaction, and path validation primitives.