github.com/ory/fosite

fix: make redirect URL checking more strict

The OAuth 2.0 Client's Redirect URL and the Redirect URL used in the OAuth 2.0 flow do not check if the query string is equal:

1. Registering a client with allowed redirect URL https://example.com/callback
2. Performing OAuth2 flow and requesting redirect URL https://example.com/callback?bar=foo
3. Instead of an error, the browser is redirected to https://example.com/callback?bar=foo with a potentially successful OAuth2 response.

Additionally, matching Redirect URLs used strings.ToLower normalization:

1. Registering a client with allowed redirect URL https://example.com/callback
2. Performing OAuth2 flow and requesting redirect URL https://example.com/CALLBACK
3. Instead of an error, the browser is redirected to https://example.com/CALLBACK with a potentially successful OAuth2 response.

This patch addresses all of these issues and adds regression tests to keep the implementation secure in future releases.

Bug Fixes

• Make redirect URL checking more strict (cdee51e):

  The OAuth 2.0 Client's Redirect URL and the Redirect URL used in the OAuth 2.0 flow do not check if the query string is equal:

  1. Registering a client with allowed redirect URL https://example.com/callback
  2. Performing OAuth2 flow and requesting redirect URL https://example.com/callback?bar=foo
  3. Instead of an error, the browser is redirected to https://example.com/callback?bar=foo with a potentially successful OAuth2 response.

  Additionally, matching Redirect URLs used strings.ToLower normalization:

  1. Registering a client with allowed redirect URL https://example.com/callback
  2. Performing OAuth2 flow and requesting redirect URL https://example.com/CALLBACK
  3. Instead of an error, the browser is redirected to https://example.com/CALLBACK with a potentially successful OAuth2 response.

  This patch addresses all of these issues and adds regression tests to keep the implementation secure in future releases.

Documentation

• Added missing dot (#487) (a822244)

chore: fix unused const linter error (#484)

Breaking Changes

fosite.ErrRevocationClientMismatch was removed because it is not part of RFC 6749. Instead, fosite.ErrUnauthorizedClient will be returned when calling RevokeToken with an OAuth2 Client which does not match the Access or Refresh Token to be revoked.

Bug Fixes

• Full JSON escaping (#481) (0943a10)
• Ignore x/net false positives (#483) (aead149)

Chores

• Fix unused const linter error (#484) (3540462)

Features

• Errors now wrap underlying errors (#479) (b53f8f5), closes #458

Unclassified

• Merge pull request from GHSA-7mqr-2v3q-v2wm (03dd558)

feat: error_hint and error_debug are now exposed through error_description (#460)

BREAKING CHANGE: Merges the error description with error hint and error debug, making it easier to consume error messages in standardized OAuth2 clients.

Breaking Changes

Merges the error description with error hint and error debug, making it easier to consume error messages in standardized OAuth2 clients.

Features

• Error_hint and error_debug are now exposed through error_description (#460) (8daab21)

autogen(docs): regenerate and update changelog

Code Generation

• docs: Regenerate and update changelog (1f16df0)

Code Refactoring

• Fix inconsistent spelling of revocation (#477) (7a55edb)

Documentation

• Fix minor typos (#475) (23cc9c1)